Support local dev in CLI #5199
Merged
Support local dev in CLI #5199
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
shauns
force-pushed
the
shauns/01-15-support_local_dev_in_cli
branch
from
4cfc184 to
de3dd04
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success2035 tests passing in 909 suites. Report generated by 🧪jest coverage report action from a86670a |
shauns
force-pushed
the
shauns/01-15-support_local_dev_in_cli
branch
from
de3dd04 to
2fe0c6a
Compare
shauns
force-pushed
the
shauns/01-15-support_local_dev_in_cli
branch
from
2fe0c6a to
a86670a
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/constants.d.ts@@ -31,6 +31,7 @@ export declare const environmentVariables: {
otelURL: string;
themeKitAccessDomain: string;
json: string;
+ neverUsePartnersApi: string;
};
export declare const defaultThemeKitAccessDomain = "theme-kit-access.shopifyapps.com";
export declare const systemEnvironmentVariables: {
packages/cli-kit/dist/public/node/environment.d.ts@@ -49,4 +49,10 @@ export declare function getIdentityTokenInformation(): {
* @param environment - Process environment variables.
* @returns True if the JSON output is enabled, false otherwise.
*/
-export declare function jsonOutputEnabled(environment?: NodeJS.ProcessEnv): boolean;
\ No newline at end of file
+export declare function jsonOutputEnabled(environment?: NodeJS.ProcessEnv): boolean;
+/**
+ * If true, the CLI should not use the Partners API.
+ *
+ * @returns True if the SHOPIFY_CLI_NEVER_USE_PARTNERS_API environment variable is set.
+ */
+export declare function blockPartnersAccess(): boolean;
\ No newline at end of file
|
shauns
commented
Jan 31, 2025
| @@ -22,6 +23,9 @@ export const NotProvidedStoreFQDNError = new AbortError( | |||
| * @returns Fully-qualified domain of the partners service we should interact with. | |||
| */ | |||
| export async function partnersFqdn(): Promise<string> { | |||
| if (blockPartnersAccess()) { | |||
| throw new BugError('Partners API is blocked by the SHOPIFY_CLI_NEVER_USE_PARTNERS_API environment variable.') | |||
There was a problem hiding this comment.
BugError because this shouldn't happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
SHOPIFY_CLI_NEVER_USE_PARTNERS_APIwhich is used for internal to Shopify requirements.