Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer injected hot reload script #5551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Defer injected hot reload script #5551

wants to merge 1 commit into from

Conversation

frandiox
Copy link
Contributor

WHY are these changes introduced?

Forgot to add defer in #4908

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@frandiox frandiox requested review from a team as code owners March 24, 2025 08:41
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@frandiox frandiox requested a review from karreiro March 24, 2025 08:42
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
76.58% (+0.01% 🔼)
9366/12230
🟡 Branches
71.82% (+0.02% 🔼)
4593/6395
🟡 Functions 76.25% 2431/3188
🟡 Lines
77.13% (+0.02% 🔼)
8854/11479
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
96.39% (-1.2% 🔻)
88.57% (-2.86% 🔻)
95.45% 100%

Test suite run success

2140 tests passing in 938 suites.

Report generated by 🧪jest coverage report action from 27f6c13

Copy link
Contributor

@isaacroldan isaacroldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this one require inner loop approval? it only modifies theme 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants