Skip to content

Identification for partner or dev dash orgs #5622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: zl/add_cli_token_support_for_app_management_and_bp_api
Choose a base branch
from
+2 −2
Draft

Identification for partner or dev dash orgs #5622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ export class AppManagementClient implements DeveloperPlatformClient {
if (!organizationsResult.currentUserAccount) return []
return organizationsResult.currentUserAccount.organizations.nodes.map((org) => ({
id: idFromEncodedGid(org.id),
businessName: org.name,
businessName: `${org.name} (Dev Dashboard)`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably confirm with Nick about namings here before merging

source: this.organizationSource,
}))
}
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/cli/utilities/developer-platform-client/partners-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@
const result = await this.requestDoc(AllOrgs)
return result.organizations.nodes!.map((org) => ({
id: org!.id,
businessName: org!.businessName,
businessName: `${org!.businessName} (Partner Dashboard)`,
source: this.organizationSource,
}))
} catch (error: unknown) {
Expand Down Expand Up @@ -583,13 +583,13 @@

if (!response.ok) {
return {
errors: data.errors || [`Request failed with status ${response.status}`],

Check warning on line 586 in packages/app/src/cli/utilities/developer-platform-client/partners-client.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/app/src/cli/utilities/developer-platform-client/partners-client.ts#L586 

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.
status: response.status,
}
}

return {
app_logs: data.app_logs || [],

Check warning on line 592 in packages/app/src/cli/utilities/developer-platform-client/partners-client.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/app/src/cli/utilities/developer-platform-client/partners-client.ts#L592 

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.
cursor: data.cursor,
status: response.status,
}
Expand Down
Loading