Skip to content

[DNM] Stop app preview #5648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

isaacroldan commented Apr 14, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@isaacroldan isaacroldan mentioned this pull request Apr 14, 2025
5 tasks
@isaacroldan isaacroldan force-pushed the 04-10-_dnm_stop_app_preview branch from 5ec6ff1 to b604454 Compare April 14, 2025 15:43
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
76.64% (-0.07% 🔻)
9489/12381
🟡 Branches 71.81% 4654/6481
🟡 Functions
76.41% (-0.05% 🔻)
2458/3217
🟡 Lines
77.17% (-0.08% 🔻)
8976/11632
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / clean.ts
0% 100% 0% 0%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88% (-4% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

2197 tests passing in 959 suites.

Report generated by 🧪jest coverage report action from b604454

Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant