Skip to content

Conversation

@nickwesselman
Copy link
Contributor

WHY are these changes introduced?

renderSingleTask for bulk uploads currently outputs to STDOUT

WHAT is this pull request doing?

Outputs it to STDERR instead.

How to test your changes?

shopify app bulk execute --variables '{"synchronous":true,"productSet":{"title":"Black Performance Crew Neck T-Shirt","descriptionHtml":"<p>Moisture-wicking crew neck t-shirt. Premium athletic wear designed for peak performance.</p>","productType":"Shirts","vendor":"Athletic Wear Co","status":"ACTIVE","tags":["athletic","shirts","training"],"productOptions":[{"name":"Size","values":[{"name":"XS"},{"name":"S"},{"name":"M"},{"name":"L"},{"name":"XL"},{"name":"XXL"}]},{"name":"Color","values":[{"name":"Black"}]}],"variants":[{"optionValues":[{"optionName":"Size","name":"XS"},{"optionName":"Color","name":"Black"}],"price":29.99},{"optionValues":[{"optionName":"Size","name":"S"},{"optionName":"Color","name":"Black"}],"price":29.99},{"optionValues":[{"optionName":"Size","name":"M"},{"optionName":"Color","name":"Black"}],"price":29.99},{"optionValues":[{"optionName":"Size","name":"L"},{"optionName":"Color","name":"Black"}],"price":29.99},{"optionValues":[{"optionName":"Size","name":"XL"},{"optionName":"Color","name":"Black"}],"price":29.99},{"optionValues":[{"optionName":"Size","name":"XXL"},{"optionName":"Color","name":"Black"}],"price":29.99}],"files":[{"originalSource":"https://picsum.photos/seed/0-shirt/1000/1000","alt":"Black Performance Crew Neck T-Shirt","contentType":"IMAGE"}]}}' --query 'mutation UpsertProduct($productSet: ProductSetInput!, $synchronous: Boolean!) {
  productSet(synchronous: $synchronous, input: $productSet) {
    product {
      id
      title
      status
    }
    userErrors {
      field
      message
    }
  }
}' --watch > test.jsonl

test.jsonl should only contain JSONL.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@nickwesselman nickwesselman requested a review from a team as a code owner December 16, 2025 19:07
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.5% (+0.27% 🔼)
14175/17830
🟡 Branches
73.56% (+0.45% 🔼)
6951/9450
🟡 Functions
79.66% (+0.29% 🔼)
3638/4567
🟡 Lines
79.87% (+0.29% 🔼)
13400/16777
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / admin-as-app.ts
100% 100% 100% 100%
🟢
... / metafield_definitions.ts
100% 100% 100% 100%
🟢
... / metaobject_definitions.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-mutation.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-query.ts
100% 100% 100% 100%
🟢
... / get-bulk-operation-by-id.ts
100% 100% 100% 100%
🟢
... / list-bulk-operations.ts
100% 100% 100% 100%
🟢
... / staged-uploads-create.ts
100% 100% 100% 100%
🔴
... / execute.ts
0% 0% 0% 0%
🔴
... / status.ts
0% 0% 0% 0%
🔴
... / pull.ts
0% 100% 0% 0%
🟢
... / execute-operation.ts
92.59% 75% 100% 92.31%
🔴
... / pull.ts
0% 0% 0% 0%
🟢
... / bulk-operation-status.ts
96.55% 92.11% 100% 100%
🟢
... / constants.ts
100% 100% 100% 100%
🟢
... / download-bulk-operation-results.ts
100% 100% 100% 100%
🟢
... / execute-bulk-operation.ts
92.65% 86.67% 100% 93.94%
🟢
... / format-bulk-operation-status.ts
100% 100% 100% 100%
🟢
... / run-mutation.ts
100% 100% 100% 100%
🟢
... / run-query.ts
100% 100% 100% 100%
🟡
... / stage-file.ts
73.53% 62.5% 85.71% 72.73%
🟢
... / watch-bulk-operation.ts
100% 94.74% 100% 100%
🟢
... / declarative-definitions.ts
98.54% 93.18% 100% 98.51%
🟢
... / common.ts
97.22% 93.75% 100% 96.55%
🟢
... / execute-command-helpers.ts
100% 100% 100% 100%
🔴
... / promiseWithResolvers.ts
33.33% 50% 50% 33.33%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / execute.ts
0%
0% (-100% 🔻)
0% 0%
🟢
... / extension-instance.ts
84.8% (+0.23% 🔼)
77.6% (-0.91% 🔻)
92.06% (+0.13% 🔼)
85.11% (+0.24% 🔼)
🟡
... / specification.ts
69.09%
75.61% (+2.44% 🔼)
76.47% (-1.31% 🔻)
68.75%
🟢
... / ui_extension.ts
85.38% (-9.44% 🔻)
72.34% (-8.91% 🔻)
84% (-16% 🔻)
88% (-8.46% 🔻)
🟢
... / developer-platform-client.ts
84.62% (-1.5% 🔻)
71.43% (+0.84% 🔼)
81.82% (+1.82% 🔼)
93.75% (+0.42% 🔼)
🟢
... / api.ts
87.07% (-0.43% 🔻)
76.71% (-0.1% 🔻)
100%
86.49% (-0.43% 🔻)
🟢
... / SingleTask.tsx
84.21% (-15.79% 🔻)
50% (-50% 🔻)
80% (-20% 🔻)
84.21% (-15.79% 🔻)
🔴
... / environment.ts
35% (-5% 🔻)
41.18%
40% (-10% 🔻)
36.84% (-5.26% 🔻)
🔴
... / ui.tsx
50.82% (-0.79% 🔻)
42.86% (-5.53% 🔻)
54.55% (+1.42% 🔼)
50% (-0.82% 🔻)
🟢
... / console.ts
81.82% (+15.15% 🔼)
75% (-25% 🔻)
100% (+33.33% 🔼)
81.82% (+15.15% 🔼)
🔴
... / dev.ts
14.29% (+0.95% 🔼)
3.13% (+0.18% 🔼)
50% (-7.14% 🔻)
14.29% (+0.95% 🔼)
🟢
... / init.ts
88% (-0.89% 🔻)
71.43% (+4.76% 🔼)
86.67% (+4.85% 🔼)
88% (-0.89% 🔻)
🟢
... / storefront-renderer.ts
90.2% (-0.54% 🔻)
78.95%
81.82% (-1.52% 🔻)
90.2% (-0.54% 🔻)
🟡
... / theme-polling.ts
67.12% (-0.93% 🔻)
68.75% 78.57%
66.67% (-0.98% 🔻)

Test suite run success

3554 tests passing in 1415 suites.

Report generated by 🧪jest coverage report action from 5aa8d03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants