[Security] Fix command injection risk in cloudflared installer#7473
[Security] Fix command injection risk in cloudflared installer#7473gonzaloriestra wants to merge 1 commit intomainfrom
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Replaced direct child_process calls with secure wrappers from @shopify/cli-kit. Switched to argument-list-based command execution to prevent shell injection. Updated unit tests to match new implementation.
34265f3 to
e00baf9
Compare
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260506091623Caution After installing, validate the version by running |
WHY are these changes introduced?
Fixes a potential command injection vulnerability in the Cloudflare installer. The previous implementation used
execSyncwith a template literal containing a variable derived from an environment variable (SHOPIFY_CLI_CLOUDFLARED_PATH), which could be exploited to execute arbitrary commands if the environment was compromised.WHAT is this pull request doing?
child_process.execSyncandchild_process.execFileSynccalls with secure wrappersexecandcaptureOutputWithExitCodefrom@shopify/cli-kit/node/system.tarto prevent shell injection.child_processimports to ensure all command executions go through@shopify/cli-kitwhich implementscheckCommandSafety.install-cloudflared.test.tsto match the new asynchronous implementation and use the correct mocks.How to test your changes?
Run the unit tests for the affected package:
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 17491907231653004163 started by @gonzaloriestra