Skip to content

Update the Text block in the Featured Product section to allow richtext instead of just inline_richtext #3689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Update the Text block in the Featured Product section to allow richtext instead of just inline_richtext #3689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sections/featured-product.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,11 +380,11 @@
render 'share-button', block: block, share_link: share_url
%}
{%- when 'variant_picker' -%}
{% render 'product-variant-picker',
product: product,
block: block,
product_form_id: product_form_id
%}

Check warning on line 387 in sections/featured-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/featured-product.liquid#L383-L387 

[NestedSnippet] Too many nested snippets

Check warning on line 387 in sections/featured-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/featured-product.liquid#L383-L387 

[NestedSnippet] Too many nested snippets

Check warning on line 387 in sections/featured-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/featured-product.liquid#L383-L387 

[NestedSnippet] Too many nested snippets
{%- when 'buy_buttons' -%}
{%- render 'buy-buttons',
block: block,
Expand Down Expand Up @@ -473,7 +473,7 @@
if product.selected_or_first_available_variant.featured_media
assign seo_media = product.selected_or_first_available_variant.featured_media
else
assign seo_media = product.featured_media

Check warning on line 476 in sections/featured-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/featured-product.liquid#L476 

[UnusedAssign] `seo_media` is never used
endif
-%}

Expand All @@ -487,7 +487,7 @@
{% endif %}
</product-info>

{% schema %}

Check notice on line 490 in sections/featured-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/featured-product.liquid#L490 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.featured-product.name",
"tag": "section",
Expand All @@ -504,7 +504,7 @@
"name": "t:sections.featured-product.blocks.text.name",
"settings": [
{
"type": "inline_richtext",
"type": "richtext",
"id": "text",
"default": "t:sections.featured-product.blocks.text.settings.text.default",
"label": "t:sections.featured-product.blocks.text.settings.text.label"
Expand Down Expand Up @@ -1476,7 +1476,7 @@
{
"type": "text",
"settings": {
"text": "{{ section.settings.product.vendor }}",
"text": "<p>{{ section.settings.product.vendor }}</p>",
"text_style": "uppercase"
}
},
Expand Down
Loading