Skip to content

Fix some shopify theme check variable name formats #3745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sections/main-article.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
class="page-width page-width--narrow{% if settings.animations_reveal_on_scroll %} scroll-trigger animate--slide-in{% endif %}"
>
{%- if article.comments_count > 0 -%}
{%- assign anchorId = '#Comments-' | append: article.id -%}
{%- assign anchor_id = '#Comments-' | append: article.id -%}

<h2 id="Comments-{{ article.id }}" tabindex="-1">
{{ 'blogs.article.comments' | t: count: article.comments_count }}
Expand All @@ -126,7 +126,7 @@
</footer>
</article>
{%- endfor -%}
{% render 'pagination', paginate: paginate, anchor: anchorId %}
{% render 'pagination', paginate: paginate, anchor: anchor_id %}
</div>
{% endpaginate %}
{%- endif -%}
Expand Down
4 changes: 2 additions & 2 deletions sections/main-list-collections.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
assign collections = collections | reverse
endif

assign moduloResult = 28 | modulo: section.settings.columns_desktop
assign modulo_result = 28 | modulo: section.settings.columns_desktop
assign paginate_by = 30
if moduloResult == 0
if modulo_result == 0
assign paginate_by = 28
endif
-%}
Expand Down
4 changes: 2 additions & 2 deletions sections/main-password-footer.liquid
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{% assign scheme1 = settings.color_schemes | first %}
{%- if section.settings.color_scheme == scheme1 -%}<hr>{%- endif -%}
{% assign scheme_1 = settings.color_schemes | first %}
{%- if section.settings.color_scheme == scheme_1 -%}<hr>{%- endif -%}
<div class="password__footer color-{{ section.settings.color_scheme }} gradient">
<ul class="list-social list-unstyled" role="list">
{%- if settings.social_twitter_link != blank -%}
Expand Down
4 changes: 2 additions & 2 deletions sections/main-password-header.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@
</password-modal>
</div>
</div>
{% assign scheme1 = settings.color_schemes | first %}
{%- if section.settings.color_scheme == scheme1 -%}<hr>{%- endif -%}
{% assign scheme_1 = settings.color_schemes | first %}
{%- if section.settings.color_scheme == scheme_1 -%}<hr>{%- endif -%}

{% schema %}
{
Expand Down