Updated Unit Price Support #3772
Conversation
sunblaze
force-pushed
the
updated-unit-price-support
branch
from
7565e40 to
5ba5e3b
Compare
This improved handling allows for languages to customize the format and also display and handle the unit being generic and not unit based in the case of item/count Also includes: - Removes whitespace around the / (eg. $1/g) - Removes styling that capitalizes the unit (eg. $1/G) - Update 4 translation files
sunblaze
force-pushed
the
updated-unit-price-support
branch
from
3ab4c72 to
9859e3e
Compare
![translation-platform[bot]](https://avatars.githubusercontent.com/in/7649?s=60&v=4){kind=small}
| </span> | ||
| </span> | ||
| </small> | ||
| {%- if use_variant -%} |
There was a problem hiding this comment.
Where does use_variant and target come from?
I'm wondering why the code changed to use these instead of product.selected_or_first_available_variant.
There was a problem hiding this comment.
Ok yeah, I see that now. It looks like we previously would have still shown the unit price from the selected or first available variant if use_variant was false, so I'd want to confirm from theme folks that this change makes sense.
|
The changes look great, here are screenshots with different scenarios: |
This comment was marked as resolved.
This comment was marked as resolved.
Remove extra dash Co-authored-by: Trish Rempel <[email protected]>
|
FYI, translations are updated as per translations review coordinated in #help-localization. |
|
Just found this PR. It feels wrong to have those translations at the theme level. Those should be provided by the platform directly. |
trishrempel
requested review from
mkevinosullivan
and removed request for
mkevinosullivan
PR Summary:
Updates unit pricing to support new units and how they're displayed with translation support.
Why are these changes introduced?
New units would not be displayed correctly without updating the theme.
What approach did you take?
Chose to implement it completely in liquid.
Other considerations
Visual impact on existing themes
Testing steps/scenarios
shopify theme pushorshopify theme packageChecklist