-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Fix/footer border #3780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/footer border #3780
Conversation
…jacent selectors and enhance styling for custom components in the Rave Yoga theme.
…jacent selectors and enhance styling for custom components in the Rave Yoga theme.
Committed from shop: RAVE
Committed from shop: RAVE
Committed from shop: RAVE
Committed from shop: RAVE
Committed from shop: RAVE
@@ -212,6 +221,9 @@ | |||
"sort_by_label": "Sort by:", | |||
"to": "To", | |||
"clear_filter": "Remove filter" | |||
}, | |||
"custom": { | |||
"custom_tab_title": "Rave Details" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Rave Details
for keyproducts.custom.custom_tab_title
is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
PR Summary:
Why are these changes introduced?
Fixes #0.
What approach did you take?
Other considerations
Decision log
Visual impact on existing themes
Testing steps/scenarios
Demo links
Checklist