feat: add discounts allocator function template (Rust, JS/TS, WASM) #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiusj
force-pushed
the
mathiuss/add-discounts-allocator
branch
4 times, most recently
from
7fec240 to
958902c
Compare
mathiusj
force-pushed
the
mathiuss/add-discounts-allocator
branch
from
958902c to
eba582e
Compare
jharlap
requested changes
Jan 24, 2024
| @@ -0,0 +1,7 @@ | |||
| query RunInput { | |||
| shop { | |||
| metafield(namespace: "$app:{{handle | replace: " ", "-" | downcase}}", key: "allocator-function") { | |||
There was a problem hiding this comment.
for other functions we've been using the key function-configuration, which I think makes the intent clearer
| @@ -0,0 +1,7 @@ | |||
| query Input { | |||
| shop { | |||
| metafield(namespace: "$app:{{handle | replace: " ", "-" | downcase}}", key: "allocator-function") { | |||
mathiusj
changed the title
discounts/rust/discounts-allocator/default/shopify.extension.toml.liquid
Outdated
Show resolved
Hide resolved
Will check it out, I thought I trimmed it to match but could have missing something! :D |
jharlap
approved these changes
Jan 25, 2024
samihibrahim
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are we solving?
Part of https://github.com/Shopify/core-issues/issues/64459
What was done
🎩 Instructions
spin up discount-functions-testing:legacy -c partners.branch=mathiusj/gh-64459-add-discounts-allocator-extensionFor each Programming Language (JS, TS, Rust, WASM)
npm run shopify app generate extension -- --template discounts_allocator --name discounts-allocator-test --clone-url https://github.com/Shopify/function-examples\#mathiuss/add-discounts-allocatoryarn && yarn testorcargo build && cargo test