Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Allocations on pickup point functions template. #488

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

soyed
Copy link
Contributor

@soyed soyed commented Apr 23, 2024

Resolves: https://github.com/Shopify/shopify/issues/499574
Tophat result: https://github.com/Shopify/function-examples-tophat/pull/13#issuecomment-2072355233

Deprecate allocations on pickup point function API Input in favour of delivery_address.
Note: allocations will continue to be supported for the time being.

@soyed soyed self-assigned this Apr 23, 2024
@soyed soyed changed the title deprecate allocations on pickup point functions template. Deprecate allocations on pickup point functions template. Apr 23, 2024
@soyed soyed changed the title Deprecate allocations on pickup point functions template. Deprecate Allocations on pickup point functions template. Apr 23, 2024
@soyed soyed marked this pull request as ready for review April 23, 2024 14:53
@soyed soyed requested review from vmrocha and SaifBenChahed April 23, 2024 14:53
Copy link

@SaifBenChahed SaifBenChahed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@soyed soyed merged commit 267e0fe into main Apr 24, 2024
7 checks passed
@soyed soyed deleted the soyed/pup-deprecate-allocations branch April 24, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants