Propagating errors instead of panicking #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adampetro
reviewed
Jan 29, 2025
There was a problem hiding this comment.
Have you tested how much adding anyhow affects the resulting binary size?
If it does have an impact on binary size, I think this is possible to do without anyhow, just using shopify_function::Result and static strings as the errors. example
Good feedback. I've made changes to not include anyhow then 👍 . |
jonathanhamel4
changed the title
adampetro
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagating errors instead of panicking. (Usage of
expectwill panic, but map_err or ok_or will not and return proper results)