Skip to content

Rename discount schema properties #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

devisscher
Copy link
Contributor

@devisscher devisscher commented Mar 21, 2025

Description

Updates discount operation names in JavaScript and Rust function examples to match new schema.

  • Updates type definitions and return types in both languages
  • Modifies test files to use new operation names
  • Update shopify.extension.toml

Part of: https://github.com/Shopify/core-issues/issues/86298

@devisscher devisscher force-pushed the rename-discount-schema branch from cc1a4f1 to 7eaea91 Compare March 21, 2025 21:01
@devisscher devisscher requested review from jonathanhamel4 and a team March 21, 2025 21:03
Copy link
Contributor

@davejcameron davejcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the shopify.extension.toml fix

@devisscher devisscher merged commit 572d795 into main Mar 24, 2025
4 checks passed
@devisscher devisscher deleted the rename-discount-schema branch March 24, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants