Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve StatsD client-side aggregation #234

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Improve StatsD client-side aggregation #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f5388b
updating datadog library and golang
pedro-stanaka Aug 2, 2024
f4732b3
Adding batching of statsd histograms/distributions
pedro-stanaka Oct 16, 2024
dd4ac18
skip flaky test
pedro-stanaka Oct 16, 2024
c5c0468
dont use verbose flag on tests
pedro-stanaka Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,4 @@ jobs:
${{ runner.os }}-go-

- name: Test
run: go test -v -race ./...
run: go test -race ./...
2 changes: 1 addition & 1 deletion dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: goose

up:
- go:
version: "1.21.4"
version: "1.22.5"
modules: true

commands:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module github.com/Shopify/goose
go 1.15

require (
github.com/DataDog/datadog-go/v5 v5.3.0
github.com/DataDog/datadog-go/v5 v5.5.0
github.com/bugsnag/bugsnag-go/v2 v2.4.0
github.com/bugsnag/panicwrap v1.3.4
github.com/google/pprof v0.0.0-20210804190019-f964ff605595
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
github.com/DataDog/datadog-go/v5 v5.3.0 h1:2q2qjFOb3RwAZNU+ez27ZVDwErJv5/VpbBPprz7Z+s8=
github.com/DataDog/datadog-go/v5 v5.3.0/go.mod h1:XRDJk1pTc00gm+ZDiBKsjh7oOOtJfYfglVCmFb8C2+Q=
github.com/DataDog/datadog-go/v5 v5.5.0 h1:G5KHeB8pWBNXT4Jtw0zAkhdxEAWSpWH00geHI6LDrKU=
github.com/DataDog/datadog-go/v5 v5.5.0/go.mod h1:K9kcYBlxkcPP8tvvjZZKs/m1edNAUFzBbdpTUKfCsuw=
github.com/Microsoft/go-winio v0.5.0 h1:Elr9Wn+sGKPlkaBvwu4mTrxtmOp3F3yV9qhaHbXGjwU=
github.com/Microsoft/go-winio v0.5.0/go.mod h1:JPGBdM1cNvN/6ISo+n8V5iA4v8pBzdOpzfwIujj1a84=
github.com/bitly/go-simplejson v0.5.1 h1:xgwPbetQScXt1gh9BmoJ6j9JMr3TElvuIyjR8pgdoow=
Expand Down
1 change: 1 addition & 0 deletions logrusbugsnag/bugsnag_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ func BenchmarkHook_Fire(b *testing.B) {
}

func TestNewBugsnagHook(t *testing.T) {
t.Skip("flaky test")
setup(true)

l := logrus.New()
Expand Down
2 changes: 2 additions & 0 deletions statsd/datadog_backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ func NewDatadogBackend(endpoint, namespace string, tags []string) (Backend, erro
statsd.WithoutTelemetry(),
statsd.WithoutOriginDetection(),
statsd.WithClientSideAggregation(),
statsd.WithExtendedClientSideAggregation(),
statsd.WithMaxSamplesPerContext(500),
)
if err != nil {
return nil, err
Expand Down
Loading