Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] chore(build): remove eslint from examples and skeleton #2711

Closed
wants to merge 2 commits into from
Closed

[DRAFT] chore(build): remove eslint from examples and skeleton #2711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44f786a
chore(build): remove eslint from examples and skeleton
liady Jan 15, 2025
964eca8
typo
liady Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/preview/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,11 @@
},
"devDependencies": {
"@remix-run/dev": "^2.15.2",
"@remix-run/eslint-config": "^2.15.2",
"@tailwindcss/vite": "4.0.0-beta.8",
"@types/he": "^1.2.1",
"@types/react": "^18.2.20",
"@types/react-dom": "^18.2.7",
"@types/react-syntax-highlighter": "^15.5.7",
"eslint": "^8.38.0",
"typescript": "^5.2.2",
"vite": "^5.1.8",
"vite-tsconfig-paths": "^4.3.1"
Expand Down
4 changes: 0 additions & 4 deletions examples/express/.eslintrc.cjs
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions examples/express/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,13 @@
},
"devDependencies": {
"@remix-run/dev": "^2.15.2",
"@remix-run/eslint-config": "^2.15.2",
"@shopify/cli": "~3.73.0",
"@types/compression": "^1.7.2",
"@types/express": "^4.17.17",
"@types/morgan": "^1.9.4",
"@types/react": "^18.2.22",
"@types/react-dom": "^18.2.7",
"dotenv": "^16.0.3",
"eslint": "^8.38.0",
"nodemon": "^2.0.22",
"npm-run-all": "^4.1.5",
"typescript": "^5.2.2",
Expand Down
2 changes: 1 addition & 1 deletion templates/TEMPLATE_GUIDELINES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Hydrogen Skeleton Template Guidelines

This initial document provides guidelines and opinionated best practices for developing in Remix and Hydrogen with the goal of building consistent and well structured code. This may evolve into more official recommendations, such as ESLint presets and other tooling to guide users to the outcomes defined below.
This initial document provides guidelines and opinionated best practices for developing in Remix and Hydrogen with the goal of building consistent and well structured code. This may evolve into more official recommendations and other tooling to guide users to the outcomes defined below.

Topics covered:

Expand Down
19 changes: 0 additions & 19 deletions templates/skeleton/.eslintrc.cjs
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions templates/skeleton/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,14 @@
"devDependencies": {
"@graphql-codegen/cli": "5.0.2",
"@remix-run/dev": "^2.15.2",
"@remix-run/eslint-config": "^2.15.2",
"@shopify/cli": "~3.73.0",
"@shopify/hydrogen-codegen": "^0.3.2",
"@shopify/mini-oxygen": "^3.1.0",
"@shopify/oxygen-workers-types": "^4.1.2",
"@shopify/prettier-config": "^1.1.2",
"@total-typescript/ts-reset": "^0.4.2",
"@types/eslint": "^8.4.10",
"@types/react": "^18.2.22",
"@types/react-dom": "^18.2.7",
"eslint": "^8.20.0",
"eslint-plugin-hydrogen": "0.12.2",
"prettier": "^2.8.4",
"typescript": "^5.2.2",
"vite": "^5.1.8",
Expand Down
Loading