Fix the customer account implementation to clear all session data on logout #2843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
logout
method on the customer account API abstraction does not clear all session data. It only clears customer account api related data. This means if the user attaches any custom data to the session, it will bleed across customer account logins.WHAT is this pull request doing?
This fixes the logout method to destroy the whole session, preventing any data from bleeding. If for some reason users want to keep custom data in the session, they can pass
keepSession: true
to the logout method:HOW to test your changes?
account.profile.tsx
page, addcontext.session.set('test', 'test ' + new Date().toISOString());
to theaction
.keepSession:true
, and make sure the session is persisted.Post-merge steps
Checklist