Refactor ProductItem and fix fragment collision in Skeleton #2872
+102
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ProductItem component to resolve a fragment collision and improve its reusability for CombinedListings and Bundles.
- Renames the local component and associated GraphQL fragment in collections.all.tsx from ProductItem to CollectionItem.
- Removes the redundant inline ProductItem definition from collections.$handle.tsx in favor of the imported version.
- Extracts the ProductItem component to its own file to enable easier reuse.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| templates/skeleton/app/routes/collections.all.tsx | Renamed the local component and updated its GraphQL fragments to resolve fragment collisions. |
| templates/skeleton/app/routes/collections.$handle.tsx | Removed inline ProductItem definition, now using the external ProductItem component. |
| templates/skeleton/app/components/ProductItem.tsx | Introduced a consolidated reusable ProductItem component supporting both fragment types. |
Comments suppressed due to low confidence (1)
templates/skeleton/app/routes/collections.all.tsx:103
- [nitpick] To maintain consistency with the new naming scheme, consider renaming 'MoneyProductItem' to 'MoneyCollectionItem'.
fragment MoneyProductItem on MoneyV2 {
juanpprieto
changed the title
ruggishop
approved these changes
Apr 22, 2025
liady
approved these changes
Apr 22, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ProductItemFragment collision between
/routes/collections.all.tsxand/routes/collections.$handle.tsxRefactor ProductItem to a component for easier recipes application in CombinedListings and Bundles. (e.g Modify one instead of two duplicated instances on each route)