Show actionable error when vite is missing in Hydrogen CLI#3796
Open
lucyxiang wants to merge 1 commit into
Open
Show actionable error when vite is missing in Hydrogen CLI#3796lucyxiang wants to merge 1 commit into
lucyxiang wants to merge 1 commit into
Conversation
`importVite()` resolved `vite` from the user's project root and let a raw
`MODULE_NOT_FOUND` ("Cannot find module 'vite'") propagate when the package
was not installed there (e.g. running a hydrogen command outside the app
directory or before installing dependencies). Because it was unhandled, it
was reported to Bugsnag as a crash.
Catch the missing-module case and throw a handled `AbortError` with
actionable next steps. Handled errors print cleanly and are not reported as
crashes; any other resolution error is re-thrown unchanged.
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
importVite()resolvedvitefrom the user's project root and let a rawMODULE_NOT_FOUND("Cannot find module 'vite'") propagate when the package was not installed there (e.g. running a hydrogen command outside the app directory or before installing dependencies). Because it was unhandled, it is reported a crash.Catch the missing-module case and throw a handled
AbortErrorwith actionable next steps. Handled errors print cleanly and are not reported as crashes; any other resolution error is re-thrown unchanged.WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist