Merge pull request #217 from eregon/ci-tweaks-investigate-truffleruby…

…-hang Add a timeout in CI and enable verbose tests for truffleruby
Shopify · Mar 11, 2024 · 5a786af · 5a786af
2 parents 71fb89c + f1c609b
commit 5a786af
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/liquid.yml b/.github/workflows/liquid.yml
@@ -3,6 +3,7 @@ on: [push, pull_request]
 jobs:
   test:
     runs-on: ubuntu-latest
+    timeout-minutes: 10
     strategy:
       matrix:
         include:
@@ -31,6 +32,7 @@ jobs:
         continue-on-error: ${{ matrix.allowed-failure }}
         env:
           LIQUID_C_PEDANTIC: 'true'
+          TEST_OPTS: '-v -s0'
         if: matrix.ruby == 'truffleruby-head'
 
       - run: bundle exec rubocop

diff --git a/ext/liquid_c/liquid_vm.c b/ext/liquid_c/liquid_vm.c
@@ -81,9 +81,10 @@ static void write_fixnum(VALUE output, VALUE fixnum)
     long capacity = rb_str_capacity(output);
 
     if (new_size > capacity) {
-        do {
-            capacity *= 2;
-        } while (new_size > capacity);
+        capacity *= 2;
+        if (new_size > capacity) {
+            capacity = new_size;
+        }
         rb_str_resize(output, capacity);
     }
     rb_str_set_len(output, new_size);