Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid float with no leading integer #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix invalid float with no leading integer #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/liquid_c/lexer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ const char *lex_one(const char *start, const char *end, lexer_token_t *token)
}
}

if (ISDIGIT(c) || c == '-') {
if (ISDIGIT(c) || (c == '-' && str + 1 < end && ISDIGIT(str[1]))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make the strict parser more strict, so could be a breaking change. We should instead use Liquid::Usage.increment to instrument this change to determine if it will break any code in practice. If we determine that it is relied upon, then I think we will need to make the corresponding strict parsing in the ruby liquid gem less strict instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #123 to instrument this usage.

int has_dot = 0;
cur = str;
while (++cur < end) {
Expand Down