Instrument float bug #123
Merged
Instrument float bug #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhu2118
force-pushed
the
pz-instrument-float-bug
branch
from
90ccf6a to
02b924e
Compare
peterzhu2118
force-pushed
the
pz-instrument-float-bug
branch
from
02b924e to
da97e3c
Compare
dylanahsmith
approved these changes
Nov 6, 2020
|
what did we learn? Can we merge the bugfix? |
|
It looks like there are still stores using this feature. I think we should fix these store/let them know about this breaking change before we fix the bug.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instruments bug #120 to determine the usage of it in production.