-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for TruffleRuby and add TruffleRuby in CI #211
Conversation
* The latter cannot be supported on TruffleRuby: oracle/truffleruby#3118 (comment)
* This RUBY_VERSION check is incorrect on non-CRuby.
Seems to be missing some more checks: |
Nevermind, you mentioned it 🤦 |
Thanks for merging! |
@casperisfine or @nirvdrum Could you rerun https://github.com/Shopify/liquid-c/actions/runs/7615407078/job/20739862301 ? The |
I know this might be a big ask, but would it be possible to make a release including these fixes? |
Done: https://github.com/Shopify/liquid-c/actions/runs/7615407078/job/20764127709
Hum, it's a bit tricky. Our team doesn't really handle that gem. It's OK for us to merge pure compatibilty patches, but cutting a release is over stepping a bit. I'll try to track down the owners and ask. |
4.2.0 is out: https://rubygems.org/gems/liquid-c/versions/4.2.0 |
Thank you! |
See the individual commits for details.
Needs oracle/truffleruby#3400 for the truffleruby-head job to pass the test suite.
(it can already be merged though, as you prefer)