Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for TruffleRuby and add TruffleRuby in CI #211

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Jan 22, 2024

See the individual commits for details.

Needs oracle/truffleruby#3400 for the truffleruby-head job to pass the test suite.
(it can already be merged though, as you prefer)

@casperisfine
Copy link
Contributor

Seems to be missing some more checks: symbol lookup error: /home/runner/work/liquid-c/liquid-c/lib/liquid_c.so: undefined symbol: rb_check_funcall

@casperisfine
Copy link
Contributor

Nevermind, you mentioned it 🤦

@casperisfine casperisfine merged commit 28f31d0 into Shopify:main Jan 22, 2024
7 checks passed
@eregon
Copy link
Contributor Author

eregon commented Jan 22, 2024

Thanks for merging!

@eregon
Copy link
Contributor Author

eregon commented Jan 23, 2024

@casperisfine or @nirvdrum Could you rerun https://github.com/Shopify/liquid-c/actions/runs/7615407078/job/20739862301 ? The rb_check_funcall PR got merged so if rerun the tests should pass and I can track if it goes red with https://github.com/eregon/truffleruby-gem-tracker.

@eregon
Copy link
Contributor Author

eregon commented Jan 23, 2024

I know this might be a big ask, but would it be possible to make a release including these fixes?
I would like to run liquid-c in yjit-bench on truffleruby. That currently uses 4.1.0: https://github.com/Shopify/yjit-bench/blob/main/benchmarks/liquid-c/Gemfile
So a 4.1.1 release or so with these fixes would be great.

@casperisfine
Copy link
Contributor

Could you rerun

Done: https://github.com/Shopify/liquid-c/actions/runs/7615407078/job/20764127709

I know this might be a big ask, but would it be possible to make a release including these fixes?

Hum, it's a bit tricky. Our team doesn't really handle that gem. It's OK for us to merge pure compatibilty patches, but cutting a release is over stepping a bit. I'll try to track down the owners and ask.

@casperisfine
Copy link
Contributor

@eregon
Copy link
Contributor Author

eregon commented Jan 24, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants