Update utf-8 validity tests to account for liquid checking encoding #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shopify/liquid#1774 introduced a pre-parsing check for valid UTF-8 encoding, and Shopify/liquid#1776 changed the raised exception to
Liquid::TemplateEncodingError
. This updates the failing test to look for the proper exception and message.It may also be a valid outcome to remove this test entirely since this behavior is really part of https://github.com/Shopify/liquid and not the c extension