This repository was archived by the owner on Jun 6, 2025. It is now read-only.
Merged
Conversation
bae23b5 to
97c5af0
Compare
size-limit report 📦
|
mollerjorge
approved these changes
Jan 8, 2025
Collaborator
mollerjorge
left a comment
There was a problem hiding this comment.
Tested edge cases values in story book (negative, cero, big and small numbers), they look good!
Thanks for adding the tests as well 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
This PR removes the main percentage label in
FunnelChartNext, and addresses a few follow up issues:Does this close any currently open issues?
What do the changes look like?
Storybook link
https://6062ad4a2d14cd0021539c1b-yjjtqaptpo.chromatic.com/
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package