This repository was archived by the owner on Jun 6, 2025. It is now read-only.
Merged
Conversation
cd53dcc to
ec8d7ae
Compare
size-limit report 📦
|
rita-morozova
approved these changes
May 2, 2025
Contributor
rita-morozova
left a comment
There was a problem hiding this comment.
🎩 'ing and code look good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
We have to render one set of annotations above the other, so in some case an annotation line will render over the annotation tooltip. This is already how
<BarChart />works, the line charts were missed.Until we can come up with a better solution to render the tooltips, we are going to prioritize rendering the xAxis annotations.
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package