Skip to content
This repository was archived by the owner on Jun 6, 2025. It is now read-only.

Comments

Render xAxis annotations above yAxisLine#1845

Merged
envex merged 1 commit intomainfrom
envex/line-chart-annotations
May 2, 2025
Merged

Render xAxis annotations above yAxisLine#1845
envex merged 1 commit intomainfrom
envex/line-chart-annotations

Conversation

@envex
Copy link
Collaborator

@envex envex commented May 2, 2025

What does this implement/fix?

We have to render one set of annotations above the other, so in some case an annotation line will render over the annotation tooltip. This is already how <BarChart /> works, the line charts were missed.

Until we can come up with a better solution to render the tooltips, we are going to prioritize rendering the xAxis annotations.

image

Before merging

  • Check your changes on a variety of browsers and devices.

  • Update the Changelog's Unreleased section with your changes.

  • Update relevant documentation, tests, and Storybook.

  • Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package

@envex envex force-pushed the envex/line-chart-annotations branch from cd53dcc to ec8d7ae Compare May 2, 2025 15:22
@envex envex requested a review from rita-morozova May 2, 2025 15:23
@github-actions
Copy link

github-actions bot commented May 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.74 KB (0%) 1.3 s (0%) 1.3 s (+27.76% 🔺) 2.5 s
polaris-viz-cjs 231.51 KB (-0.02% 🔽) 4.7 s (-0.02% 🔽) 1.9 s (-17.83% 🔽) 6.5 s
polaris-viz-esm 187.92 KB (-0.01% 🔽) 3.8 s (-0.01% 🔽) 1.4 s (-19.66% 🔽) 5.1 s
polaris-viz-css 6.05 KB (0%) 122 ms (0%) 338 ms (-26.58% 🔽) 459 ms
polaris-viz-esnext 194.69 KB (-0.01% 🔽) 3.9 s (-0.01% 🔽) 1.6 s (+4.43% 🔺) 5.4 s

Copy link
Contributor

@rita-morozova rita-morozova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 'ing and code look good to me

@envex envex merged commit 3e64e9f into main May 2, 2025
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants