This repository was archived by the owner on Jun 6, 2025. It is now read-only.
Add new LineChartCumulative visualization #1855
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Initial implementation for new
LineChartCumulativevisualizationAddress this task: https://github.com/Shopify/merchant-analytics-issues/issues/617
For this first iteration this visualization will be rendered inside
HomeCardsso they are not interactive at the moment.figma link: https://www.figma.com/design/9Sm7SuRkGTNTCgonxhXnWO/Push-insights-to-home-proposal?node-id=1105-5699&p=f&t=0qHDAS5ng3x6stIA-0
What do the changes look like?
Storybook link
passanelli/add_cumulative_line_chartpnpm storybookCharts->LineChartCumulativeBefore merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package