Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FullscreenBar] Fix invisible BackButton color within Styleguide #13054

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[FullscreenBar] Fix invisible BackButton color within Styleguide #13054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
721db3e
:art: [Frame] Scope NavItem interface import as a type
beefchimi Jan 17, 2025
d239d5c
:bug: [FullscreenBar] Explicit button color
beefchimi Jan 17, 2025
9cc1b7d
:memo: [Report] Add changesets
beefchimi Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/unlucky-frogs-repair.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'polaris.shopify.com': patch
'@shopify/polaris': patch
---

Explicit color provided for `FullscreenBar > BackButton`.
1 change: 1 addition & 0 deletions polaris-react/src/components/FullscreenBar/FullscreenBar.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
align-items: center;
padding-left: var(--p-space-400);
padding-right: var(--p-space-400);
color: var(--p-color-text);
border-width: 0;
border-right: var(--p-border-width-025) solid var(--p-color-border-secondary);
background-color: var(--p-color-bg-surface);
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/src/components/Frame/Frame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {motion, AnimatePresence} from 'framer-motion';

import GlobalSearch from '../GlobalSearch';
import nav from '../../../.cache/nav';
import {NavItem, Breakpoints} from '../../types';
import {type NavItem, Breakpoints} from '../../types';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change because the IDE was complaining. We define NavItem as a component elsewhere in the file.


import styles from './Frame.module.scss';
import {className} from '../../utils/various';
Expand Down
Loading