Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate dist localization JSONs with upgraded json gem version #599

Conversation

danielpgross
Copy link
Collaborator

@danielpgross danielpgross commented Mar 18, 2025

#570 upgraded the json gem, resulting in a slight change to how empty arrays are generated.

old format:

attributes: [

]

new format:

attributes: []

To generate these changes, I simply ran bin/product_taxonomy dist --locales=all on latest main

@danielpgross danielpgross changed the title Remove dist localization JSON empty array whitespace Regenerate dist localization JSONs with upgraded json gem version Mar 18, 2025
@danielpgross danielpgross marked this pull request as ready for review March 18, 2025 18:01
@ricardotejedorsanz ricardotejedorsanz merged commit c34c1b1 into main Mar 19, 2025
6 checks passed
@ricardotejedorsanz ricardotejedorsanz deleted the 03-18-remove_dist_localization_json_empty_array_whitespace branch March 19, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants