-
Notifications
You must be signed in to change notification settings - Fork 63
Extend localization sync command to support return reasons #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ricardotejedorsanz
wants to merge
1
commit into
rt/return-reasons-models-and-dist
Choose a base branch
from
rt/return-reasons-sync-localizations
base: rt/return-reasons-models-and-dist
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Extend localization sync command to support return reasons #795
ricardotejedorsanz
wants to merge
1
commit into
rt/return-reasons-models-and-dist
from
rt/return-reasons-sync-localizations
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2025
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bb920bc to
7ac44ab
Compare
3b9db89 to
0bd1887
Compare
7ac44ab to
6407bfb
Compare
jmignac
reviewed
Nov 11, 2025
0bd1887 to
b0ea0e1
Compare
6407bfb to
2a5b30e
Compare
2a5b30e to
9cab054
Compare
e95fa02 to
1c7d788
Compare
0cba42e to
496e3a1
Compare
496e3a1 to
09991bd
Compare
1c7d788 to
0c9ee93
Compare
09991bd to
95e05cc
Compare
95e05cc to
09991bd
Compare
09991bd to
95e05cc
Compare
95e05cc to
09991bd
Compare
0c9ee93 to
ed70e6b
Compare
09991bd to
4f42381
Compare
4f42381 to
e71dcc6
Compare
e71dcc6 to
4f42381
Compare
08cc077 to
8bf62c6
Compare
ed70e6b to
f33f738
Compare
f33f738 to
6f43dd6
Compare
8bf62c6 to
3c0e3ac
Compare
- Update sync_en_localizations_command.rb to add return_reasons target - Enable syncing return reasons English localizations - Maintains backward compatibility with existing targets - Uses existing localizations_serializer for consistent output - Establishes foundation for multi-locale support
3c0e3ac to
f0ee5dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR enhances the existing
sync_en_localizationscommand to support return reasons, enabling automatic synchronization of English translations from the data files to the localization files.Command usage:
What it does:
data/return_reasons.ymldata/localizations/return_reasons/en.ymlWhy this matters:
Localization file structure:
Localization strategy:
With open-sourcing, return reasons should follow the same localization workflow as taxonomy fields through the public repo. Long-term, this means:
However, for the initial batch rollout, we suggest to use a pragmatic approach:
Design decisions:
return_reasonsas a valid target alongsidecategories,attributes,valueslocalizations_serializer.rbfor consistent outputReview notes:
sync_en_localizations_command.rb: adds return_reasons casecommand.rbif shared localization logic was extractedFiles to Include
dev/lib/product_taxonomy/commands/sync_en_localizations_command.rbdev/lib/product_taxonomy/commands/command.rb(if there are shared changes)Dependencies
Review Focus