Skip to content

Check shims duplicate in CI#444

Merged
Morriar merged 2 commits intomainfrom
at-clean-shims
Apr 10, 2025
Merged

Check shims duplicate in CI#444
Morriar merged 2 commits intomainfrom
at-clean-shims

Conversation

@Morriar
Copy link
Copy Markdown
Contributor

@Morriar Morriar commented Mar 28, 2025

I found a duplicate that should have been caught on CI.

@Morriar Morriar added the chore Chore task label Mar 28, 2025
@Morriar Morriar self-assigned this Mar 28, 2025
@Morriar Morriar requested a review from a team as a code owner March 28, 2025 14:18
Comment thread .github/workflows/main.yml Outdated
run: bin/export-rbi --check-sync

- name: Check shims
run bin/tapioca check-shims
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run bin/tapioca check-shims
run: bin/tapioca check-shims

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Morriar added 2 commits April 10, 2025 11:39
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar merged commit 3de82eb into main Apr 10, 2025
8 checks passed
@Morriar Morriar deleted the at-clean-shims branch April 10, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chore task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants