Skip to content

Mark Prism::Visitor methods as @override #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Morriar merged 1 commit into from
Apr 24, 2025
Merged

Mark Prism::Visitor methods as @override #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/rbi/parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,6 +961,7 @@ def initialize(source, begin_offset, end_offset)
@offset_last_newline = false #: bool
end

# @override
#: (Prism::StringNode node) -> void
def visit_string_node(node)
return unless node.heredoc?
Expand All @@ -971,6 +972,7 @@ def visit_string_node(node)
handle_string_node(node)
end

# @override
#: (Prism::InterpolatedStringNode node) -> void
def visit_interpolated_string_node(node)
return super unless node.heredoc?
Expand Down
4 changes: 2 additions & 2 deletions rbi/rbi.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,10 +1013,10 @@ class RBI::Parser::HeredocLocationVisitor < ::Prism::Visitor
sig { returns(::Prism::Location) }
def location; end

sig { params(node: ::Prism::InterpolatedStringNode).void }
sig { override.params(node: ::Prism::InterpolatedStringNode).void }
def visit_interpolated_string_node(node); end

sig { params(node: ::Prism::StringNode).void }
sig { override.params(node: ::Prism::StringNode).void }
def visit_string_node(node); end

private
Expand Down