Skip to content

Fix missing :: prefix on T::Boolean, T::Class, and T::Module in to_rbi#589

Merged
Morriar merged 1 commit intomainfrom
at/fix-to-rbi-prefix
Apr 21, 2026
Merged

Fix missing :: prefix on T::Boolean, T::Class, and T::Module in to_rbi#589
Morriar merged 1 commit intomainfrom
at/fix-to-rbi-prefix

Conversation

@Morriar
Copy link
Copy Markdown
Contributor

@Morriar Morriar commented Apr 14, 2026

Summary

  • Boolean#to_rbi, Class#to_rbi, and Module#to_rbi were returning T::Boolean, T::Class[...], and T::Module[...] without the :: prefix
  • All other to_rbi methods already correctly used fully qualified names (e.g., ::T.anything, ::T.nilable(...), ::T.proc)
  • Fixed all three to return ::T::Boolean, ::T::Class[...], and ::T::Module[...]

Test plan

  • Updated test expectations in type_test.rb to match the new output
  • All 497 tests pass

@Morriar Morriar requested a review from a team as a code owner April 14, 2026 20:46
@Morriar
Copy link
Copy Markdown
Contributor Author

Morriar commented Apr 14, 2026

cc @jesse-shopify

@Morriar Morriar changed the title Fix missing :: prefix on T::Boolean, T::Class, and T::Module in to_rbi Fix missing :: prefix on T::Boolean, T::Class, and T::Module in to_rbi Apr 14, 2026
Copy link
Copy Markdown
Contributor

@jesse-shopify jesse-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This will fix the errors I ran into.

@Morriar Morriar merged commit 086022e into main Apr 21, 2026
11 checks passed
@Morriar Morriar deleted the at/fix-to-rbi-prefix branch April 21, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants