Add erase_generic_types option to RBS translators#611
Draft
dejmedus wants to merge 2 commits into
Draft
Conversation
Previously, `RBS::TypeTranslator` and `RBS::MethodTypeTranslator` always translated generic types like `Foo[Bar]`. However, `sorbet-runtime` is unable to enforce them, so they are superfluous in runtime contexts This commit adds a default `false` `erase_generic_types` kwarg to both translators. When set to `true` generic types are dropped and the simple type is returned (`Foo[Bar]` to `Foo`)
amomchilov
reviewed
Jun 9, 2026
Comment on lines
-10
to
-12
| #: (Method, ::RBS::MethodType) -> Sig | ||
| def translate(method, type) | ||
| translator = new(method) |
Contributor
There was a problem hiding this comment.
This method is just a shim for backwards-compatibility, so there's no need to also add this option here.
Users who want the new API can just switch to .new.
Comment on lines
24
to
+25
| @result = Sig.new #: Sig | ||
| @type_translator = TypeTranslator.new #: TypeTranslator | ||
| @erase_generic_types = erase_generic_types |
Contributor
There was a problem hiding this comment.
Style nit, keep the ivars initialized from the params first and in-order
Suggested change
| @result = Sig.new #: Sig | |
| @type_translator = TypeTranslator.new #: TypeTranslator | |
| @erase_generic_types = erase_generic_types | |
| @erase_generic_types = erase_generic_types | |
| @result = Sig.new #: Sig | |
| @type_translator = TypeTranslator.new #: TypeTranslator |
| Type.proc.params(arg0: Type.untyped).returns(Type.untyped) | ||
| when ::RBS::Types::Variable | ||
| Type.type_parameter(type.name) | ||
| @erase_generic_types ? Type.untyped : Type.type_parameter(type.name) |
Contributor
There was a problem hiding this comment.
Rewrite into T.anything rather than T.untyped. It conveys a more specific specific intent.
Suggested change
| @erase_generic_types ? Type.untyped : Type.type_parameter(type.name) | |
| @erase_generic_types ? Type.anything : Type.type_parameter(type.name) |
| assert_equal( | ||
| [ | ||
| SigParam.new("array", Type.simple("Array")), | ||
| SigParam.new("item", Type.untyped), |
Contributor
There was a problem hiding this comment.
Will need to update the tests to match, e.g.
Suggested change
| SigParam.new("item", Type.untyped), | |
| SigParam.new("item", Type.anything), |
Comment on lines
+105
to
+108
| def test_translate_variable | ||
| assert_equal(Type.type_parameter(:T), translate_variable(:T)) | ||
| assert_equal(Type.type_parameter(:E), translate_variable(:E)) | ||
| end |
Contributor
There was a problem hiding this comment.
Oh interesting, I guess this wasn't covered directly before, but indirectly via test/rbi/rbs/method_type_translator_test.rb
Comment on lines
+123
to
+127
| assert_equal(Type.class_of(Type.simple("Foo")), translate("singleton(Foo)", erase_generic_types: true)) | ||
| assert_equal( | ||
| Type.class_of(Type.simple("Foo")), | ||
| translate("singleton(Foo)[Bar]", erase_generic_types: true), | ||
| ) |
Contributor
There was a problem hiding this comment.
Notably, the expected value is the same in both cases. You can emphasize that by extracting the variable in common:
Suggested change
| assert_equal(Type.class_of(Type.simple("Foo")), translate("singleton(Foo)", erase_generic_types: true)) | |
| assert_equal( | |
| Type.class_of(Type.simple("Foo")), | |
| translate("singleton(Foo)[Bar]", erase_generic_types: true), | |
| ) | |
| expected = Type.class_of(Type.simple("Foo")) | |
| assert_equal(expected, translate("singleton(Foo)", erase_generic_types: true)) | |
| assert_equal( | |
| expected, | |
| translate("singleton(Foo)[Bar]", erase_generic_types: true), | |
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP, implementation will change