Do not instantiate Public visibility for implicit public defs and attrs - #658
Open
Morriar wants to merge 2 commits into
Open
Do not instantiate Public visibility for implicit public defs and attrs#658Morriar wants to merge 2 commits into
Public visibility for implicit public defs and attrs#658Morriar wants to merge 2 commits into
Conversation
…ttrs Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
michaelherold
approved these changes
Aug 28, 2026
vinistock
approved these changes
Sep 4, 2026
| end | ||
|
|
||
| # Shared default instance to avoid allocating a new Public on every Method/Attr creation. | ||
| DEFAULT = new.freeze #: Public |
Member
There was a problem hiding this comment.
If the implicit one is now represented by nil, could we make loc required for the visibility instances?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can use
nilto represent implicit public default visibility.cc. @michaelherold.