Centralize tool result error handling in format with error_line helper#948
Draft
LasmarKhalifa wants to merge 1 commit into
Draft
Centralize tool result error handling in format with error_line helper#948LasmarKhalifa wants to merge 1 commit into
LasmarKhalifa wants to merge 1 commit into
Conversation
Contributor
Author
d674c9e to
9a40624
Compare
This was referenced Jun 15, 2026
9a40624 to
d0ec520
Compare
This was referenced Jun 16, 2026
juniper-shopify
requested changes
Jun 17, 2026
Contributor
There was a problem hiding this comment.
Nice foundation PR! The error-handling centralization is clean — pulling the error path into an early-return at the top of format means every downstream formatter only needs to think about the success case. Makes the rest of your stack cleaner.
Two small things to address:
- The
error_linedoc comment could use a couple of examples (see inline comment). - A test for
error_linewhencontentis nil would round out the edge-case coverage.
And lets switch to the xml parser we had talked about
d0ec520 to
dca3a40
Compare
dca3a40 to
504729d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.