Use Ruby 3.4 #552
Merged
Use Ruby 3.4 #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/use-ruby-3.4
branch
from
7e1eafa to
50fa4f9
Compare
andyw8
commented
Jan 7, 2025
| @@ -12,7 +12,7 @@ jobs: | |||
| gemfile: | |||
| - Gemfile | |||
| - gemfiles/Gemfile-rails-main | |||
| ruby: ["3.2", "3.3"] | |||
| ruby: ["3.3", "3.4"] | |||
There was a problem hiding this comment.
Testing the latest + previous should be sufficient for Rails. We test a wider range of Rubies in ruby-lsp's CI.
andyw8
force-pushed
the
andyw8/use-ruby-3.4
branch
from
50fa4f9 to
7c75382
Compare
andyw8
commented
Jan 7, 2025
| @@ -268,10 +278,16 @@ GEM | |||
| zeitwerk (2.7.1) | |||
|
|
|||
| PLATFORMS | |||
| aarch64-linux | |||
There was a problem hiding this comment.
These extra platforms are because Bundler suggested running bundle lock --normalize-platforms.
vinistock
approved these changes
Jan 7, 2025
andyw8
force-pushed
the
andyw8/use-ruby-3.4
branch
from
1598c4a to
d893a98
Compare
andyw8
force-pushed
the
andyw8/use-ruby-3.4
branch
from
d893a98 to
5ba97d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.