Set buffer encoding when running activation script #3079
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've been getting some errors in telemetry when transforming the activation hash into a JSON complaining that there's no conversion between ASCII-8BIT and UTF-8. Indeed, there's no way to convert the encodings properly, but I don't understand why the encoding is ASCII-8BIT to begin with.
I tried setting
LANG=C
,LC_ALL=C
and changed a bunch of VS Code settings, but I'm still unable to reproduce the issue. I want to try forcing the Buffer encoding to be UTF-8 when running the activation script, in hopes that this will fix the issue.Implementation
Started setting the encoding for the exec call.
Automated Tests
Adjusted our existing tests.