Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set buffer encoding when running activation script #3079

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Jan 17, 2025

Motivation

We've been getting some errors in telemetry when transforming the activation hash into a JSON complaining that there's no conversion between ASCII-8BIT and UTF-8. Indeed, there's no way to convert the encodings properly, but I don't understand why the encoding is ASCII-8BIT to begin with.

I tried setting LANG=C, LC_ALL=C and changed a bunch of VS Code settings, but I'm still unable to reproduce the issue. I want to try forcing the Buffer encoding to be UTF-8 when running the activation script, in hopes that this will fix the issue.

Implementation

Started setting the encoding for the exec call.

Automated Tests

Adjusted our existing tests.

@vinistock vinistock added vscode This pull request should be included in the VS Code extension's release notes bugfix This PR will fix an existing bug labels Jan 17, 2025 — with Graphite App
@vinistock vinistock self-assigned this Jan 17, 2025
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock requested review from andyw8 and st0012 January 17, 2025 20:56
@vinistock vinistock marked this pull request as ready for review January 17, 2025 20:59
@vinistock vinistock requested a review from a team as a code owner January 17, 2025 20:59
Copy link
Member Author

I'm working on a different approach that I believe will be more robust. Ignore this PR.

@vinistock vinistock closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant