-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract constant_name
method
#3136
Conversation
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
60a4ade
to
3ef4123
Compare
@vinistock I've removed the methods that were solely for delegating, but I had intentionally done it that way as I think it improves readability, since there is less noise around those calls. |
Co-authored-by: Vinicius Stock <[email protected]>
Ah, actually, let's keep only the one in But let's leave it just to avoid the breaking change, we can use |
This came up while pairing on #3031
@vinistock you initially suggested extracting to
GlobalState
but it's also used inReferenceFinder
, so I think having onIndex
makes more sense?