Skip to content

Improve support for hovering over a gem in Gemfile #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Mar 22, 2025

Motivation

Currently you can hover over an entry in the Gemfile to reveal information about a gem, but this works only for the gem call and not the string containing the gem name.

Implementation

Added behaviour to the on_string_node_enter callback.

Automated Tests

Included

Manual Tests

Can be verified with Ruby LSP's own Gemfile, using this branch.

Copy link

graphite-app bot commented Mar 22, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@andyw8 andyw8 marked this pull request as ready for review March 22, 2025 18:41
@andyw8 andyw8 requested a review from a team as a code owner March 22, 2025 18:41
@andyw8 andyw8 force-pushed the andyw8/gemfile-hover-over-name branch 2 times, most recently from fd32e5d to f1de537 Compare March 22, 2025 22:47
@vinistock vinistock added bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes labels Apr 29, 2025
@andyw8 andyw8 force-pushed the andyw8/gemfile-hover-over-name branch 4 times, most recently from 9988e74 to 8412ffd Compare April 29, 2025 20:31
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks!

@vinistock
Copy link
Member

I totally forgot to merge this. Do you mind rebasing, so that we can ship?

@andyw8 andyw8 force-pushed the andyw8/gemfile-hover-over-name branch from 8412ffd to 8b00b64 Compare May 8, 2025 21:00
@andyw8
Copy link
Contributor Author

andyw8 commented May 8, 2025

np, I've rebased.

@vinistock vinistock merged commit eddf91a into Shopify:main May 9, 2025
23 checks passed
@vinistock
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants