Improve support for hovering over a gem in Gemfile #3344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
andyw8
commented
Mar 22, 2025
| @@ -92,6 +92,14 @@ def initialize(response_builder, global_state, uri, node_context, dispatcher, so | |||
|
|
|||
| #: (Prism::StringNode node) -> void | |||
| def on_string_node_enter(node) | |||
| if @path && File.basename(@path) == GEMFILE_NAME | |||
There was a problem hiding this comment.
This is the same check as in on_call_node_enter. It could be extracted out, e.g. is_gemfile?.
andyw8
force-pushed
the
andyw8/gemfile-hover-over-name
branch
from
a5fb4df to
fd32e5d
Compare
andyw8
force-pushed
the
andyw8/gemfile-hover-over-name
branch
from
fd32e5d to
f1de537
Compare
andyw8
commented
Mar 22, 2025
| source = <<~RUBY | ||
| gem 'rake' | ||
| RUBY | ||
|
|
||
| # We need to pretend that Sorbet is not a dependency or else we can't properly test |
There was a problem hiding this comment.
Not needed, I think these were leftover from a copy and paste.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently you can hover over an entry in the
Gemfileto reveal information about a gem, but this works only for thegemcall and not the string containing the gem name.Implementation
Added behaviour to the
on_string_node_entercallback.Automated Tests
Included
Manual Tests
Can be verified with Ruby LSP's own Gemfile, using this branch.