-
Notifications
You must be signed in to change notification settings - Fork 198
Add Experimental MCP Support #3396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
ec7daf7
to
9a95003
Compare
Signed-off-by: Stan Lo <[email protected]>
@@ -0,0 +1,41 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Do we want to use #!/bin/sh
instead? Not a huge problem, almost everyone will have bash and then you don't need to worry about compatibility across shells.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the very least, I would set -eu
here to make the script safer.
#!/bin/bash | ||
|
||
# Determine script location and workspace path | ||
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit hard to read and the &&
introduces an extra failure mode. Maybe SCRIPT_DIR=$(realpath $(dirname ${BASH_SOURCE[0]}))
?
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
WORKSPACE_RUBY_LSP_DIR="$(dirname "$SCRIPT_DIR")/.ruby-lsp" | ||
PORT_FILE="$WORKSPACE_RUBY_LSP_DIR/mcp-port" | ||
LOG_PATH="$WORKSPACE_RUBY_LSP_DIR/mcp-bridge.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOG_FILE
for name consistency with PORT_FILE
?
response=$(curl -s -X POST -H "Content-Type: application/json" \ | ||
-H "Content-Length: ${#line}" \ | ||
--data "$line" \ | ||
"http://127.0.0.1:$PORT/mcp" 2>$LOG_PATH) || { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "http://127.0.0.1:$PORT/mcp" 2>$LOG_PATH) || {
, my understanding is that 2>
would clobber the file and erase old logs.
# Clean up port file | ||
lsp_dir = File.join(@workspace_path, ".ruby-lsp") | ||
port_file = File.join(lsp_dir, "mcp-port") | ||
File.delete(port_file) if File.exist?(port_file) | ||
|
||
# Clean up log file | ||
log_file = File.join(lsp_dir, "mcp-webrick.log") | ||
File.delete(log_file) if File.exist?(log_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should wrap this in an ensure
, or we're skipping cleanup on errors.
Add Model Context Protocol (MCP) support to Ruby LSP
This PR adds support for the Model Context Protocol (MCP), enabling AI assistants to programmatically access Ruby project indexes and file contents that Ruby LSP already collects.
Connection Mechanism
The implementation uses a hybrid approach:
ruby-mcp-bridge
) connects the editor's MCP client to our HTTP serverArchitecture Diagram
Editor Setup
VS Code Configuration
Add to
.vscode/mcp.json
:See VS Code MCP documentation for more details.
Cursor Configuration
Add to
.cursor/mcp.json
:See Cursor MCP documentation for more details.
Notes For Manual Testing
This feature requires both the extension and server changes to work. So for testing:
gem "ruby-lsp", github: "Shopify/ruby-lsp", branch: "mcp"
Known Issues
gets
in the LSP communication channel. This issue may be specific to Cursor as it doesn't occur (or occurs much less frequently) in VS Code, and more often in certain projects (e.g.ruby/irb
) than others. The cause may be related to how Cursor handles MCP/LSP requests and requires more investigation.Supported Tools (TBD)
The MCP server provides four tools:
read_ruby_files - Access file contents, including from dependenciesThese tools enable AI assistants to understand Ruby code structure, navigate dependencies, and access relevant documentation that are not accessible through the editor's simple codebase indexing.