Avoid recursion when collecting prefix tree node values

[vinistock]

Motivation

I noticed we were using recursion to accumulate all of the values in a prefix tree node and its children. Recursion can be quite slow, so I took a stab at removing it with a queue mechanism.

Implementation

The idea is to accumulate nodes in the queue and then pop one by one, adding to the result when appropriate.

On my benchmarks with a small sized tree, this approach is 2x faster than using recursion.

Note: we now push the values into the result in a slightly different order. I updated the tests to match. Notice that this makes no difference for our usages for completion since the editor is expected to sort the entries based on the sortText property.

[vinistock]

• Avoid recursion when collecting prefix tree node values #3401 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.