Automatically discover children of workspace test items#3448
Merged
vinistock merged 1 commit intoMay 6, 2025
Merged
Conversation
vinistock
added
bugfix
Graphite App
Member
Author
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
alexcrocha
approved these changes
May 6, 2025
vinistock
deleted the
05-02-automatically_discover_children_of_workspace_test_items
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part of the reason why code lens wasn't working in the new test explorer is because we weren't auto discovering children of workspace test items (and the LSP repo itself has multiple workspaces).
Implementation
Just like we auto discover the workspace items themselves, we need to also do the same for their children.
Note that this only necessary when there are multiple workspaces. With a single one, we eagerly discover.
Automated Tests
Added a test that fails before the fix.