Skip to content

Allow to disable any addon in the addon settings. #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

domingo2000
Copy link
Contributor

@domingo2000 domingo2000 commented May 22, 2025

Motivation

Closes #3418

Implementation

In addon loading check for the addon settings first. The addon can be disabled using

"rubyLsp.addonSettings": {
    "RuboCop": {
      "enabled": false
    }
  }

We make the addons enabled by default.

Automated Tests

Added tests when the addon is enabled and when the addon is disabled. The other tests are already testing if the setting is not set.

Manual Tests

Tests in the same repo enabling/disabling a dummy addon.

Screencast.from.21-05-25.22.27.12.webm

@domingo2000 domingo2000 requested a review from a team as a code owner May 22, 2025 02:30
Copy link

graphite-app bot commented May 22, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@domingo2000
Copy link
Contributor Author

I can also write some documentation for this if needed. Just let me know where it should go and what kind of UX writing would work best. 📝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling project addons
1 participant