Replace LanguageServer::Protocol::Transport with our own implementation #3533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the first step in removing the
language-server_protocol
dependency, in our efforts to minimize runtime dependencies that risk blocking the LSP's auto upgrades.This PR replaces the
Transport
module with our own implementation. This is not a breaking change as add-ons were already not supposed to try to read or write messages to the client directly without going through the Ruby LSP.Implementation
Implemented super simple reader and writer classes that embed the JSON RPC format for any IO. This will also make it easier to support booting the language server via sockets.
Automated Tests
There's a subtle important aspect of this. We need to capture the handles for the stdio pipes before changing the default output device (
$>
) or else communication is broken.I added an integration test that will use the current launcher with an older server version to ensure that this works even when trying to boot previous versions.