Decouple Ruby tests from specific machine setup#4088
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
alexcrocha
approved these changes
Apr 30, 2026
Base automatically changed from
04-24-decouple_shadowenv_test_from_specific_dev_setup
to
main
May 6, 2026 15:10
vinistock
force-pushed
the
04-28-decouple_ruby_tests_from_specific_machine_setup
branch
from
53c4ba1 to
0751ffd
Compare
vinistock
deleted the
04-28-decouple_ruby_tests_from_specific_machine_setup
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Another step towards #2877
Our Ruby test was also coupled with specific machine setups and was in fact failing locally due to recent changes. This PR decouples the test from specific setups, so that contributors (and our own team) can always run these.
Implementation
I extracted a better helper for stubbing VS Code settings since this is repeated pattern in our tests. Then refactored the Ruby activation tests to verify logic with stubs rather than shelling out.