Partially migrate completion to Rubydex#4096
Merged
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom May 8, 2026
Merged
Partially migrate completion to Rubydex#4096vinistock merged 1 commit intorubydex_adoption_feature_branchfrom
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom
Conversation
vinistock
added
server
19 tasks
vinistock
force-pushed
the
vs_migrate_completion_to_rubydex
branch
2 times, most recently
from
07c1526 to
e6c4e7a
Compare
Morriar
approved these changes
May 8, 2026
vinistock
force-pushed
the
vs_migrate_completion_to_rubydex
branch
from
e6c4e7a to
447395c
Compare
vinistock
merged commit c516b6e
into
rubydex_adoption_feature_branch
34 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR partially migrates completion to use Rubydex. There are still some crashes and bugs that I identified, but at least it gets us half way there.
Implementation
The previous way completion was implemented was honestly not very good or correct, so unfortunately this is basically a complete re-write using Rubydex as the completion engine.
It might honestly be easier to open this branch and read the code in its entirety.
Automated Tests
Added a few more tests.