Create IndexResult for individual file indexing result#285
Merged
jenny-codes merged 1 commit intomainfrom Oct 31, 2025
Merged
Conversation
This was referenced Oct 30, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jenny-codes
commented
Oct 30, 2025
| #[must_use] | ||
| pub fn into_parts(self) -> IndexerParts { | ||
| (Some(self.local_graph), self.errors) | ||
| (self.local_graph, self.errors) |
Contributor
Author
There was a problem hiding this comment.
There is another potential refactoring opportunity here to simply return the local_graph and not the errors, as the current code does not actually store any error from the indexing. What do we think?
jenny-codes
force-pushed
the
jennyshih/create-index-result
branch
from
63950f8 to
943e408
Compare
jenny-codes
changed the title
jenny-codes
commented
Oct 30, 2025
| } | ||
|
|
||
| pub enum IndexResult { | ||
| Completed(Box<IndexerParts>), |
Contributor
Author
There was a problem hiding this comment.
We want to box this one because the byte differences between the three variants are big.
vinistock
approved these changes
Oct 30, 2025
jenny-codes
force-pushed
the
jennyshih/create-index-result
branch
from
943e408 to
5957ec7
Compare
jenny-codes
force-pushed
the
jennyshih/multiple-error
branch
2 times, most recently
from
104f79c to
9241f5d
Compare
jenny-codes
force-pushed
the
jennyshih/create-index-result
branch
from
5957ec7 to
4fd17e1
Compare
Morriar
approved these changes
Oct 31, 2025
jenny-codes
changed the base branch from
jennyshih/multiple-error
to
graphite-base/285
jenny-codes
force-pushed
the
graphite-base/285
branch
from
9241f5d to
d298c0e
Compare
jenny-codes
force-pushed
the
jennyshih/create-index-result
branch
from
4fd17e1 to
4bc044d
Compare
jenny-codes
force-pushed
the
jennyshih/create-index-result
branch
from
4bc044d to
89a65e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To convey the outcome of individual indexing more clearly