Open
Conversation
54bc228 to
5dc2e67
Compare
5dc2e67 to
1ba8c9c
Compare
st0012
commented
May 3, 2026
1ba8c9c to
613bc62
Compare
st0012
commented
May 4, 2026
613bc62 to
7bf434b
Compare
st0012
commented
May 4, 2026
a2ac367 to
d83e97c
Compare
d83e97c to
f5dff8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes singleton class lifecycle cleanup during document deletion and re-indexing. Singleton classes are now pruned only when they are no longer anchored by definitions, members, constant references, or surviving
extendmixins on their attached object.The cleanup path is split into focused steps for method references, constant references, unmapped definitions, raw definition entries, and declaration pruning. Removability is checked through the graph so singleton classes can account for external anchors, while TODO parents are not kept alive by unresolved references alone.
The invalidation worklist now keeps declaration lifecycle modes under
InvalidationItem::Declaration { id, reason }, so declaration-specific invalidation reasons stay localized instead of widening the top-level work item enum.